Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to force fail dependent tests #34081

Closed
wants to merge 13 commits into from

Conversation

JacksonLei123
Copy link

Adding the option in playwright config to fail all tests in a project suite when one of its dependencies fail. Previously the tests are just skipped. References issue #32378

Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:291:3 › should use SOCKS proxy for websocket requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/selector-generator.spec.ts:483:5 › selector generator › should prefer role other input[type] @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37394 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman
Copy link
Member

There is no open-to-a-pr label on the issue, which means we are not accepting patches for it. It'll probably get closed during the next batch triage due to inactivity. File your own issue if you want to build the case for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants